chore(e2e-tests): consistently wait for successful exits of shell MONGOSH-1943 #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
addaleax
force-pushed
the
1943-e2e
branch
2 times, most recently
from
f11536f to
8359b73
Compare
Do not use unqualified `shell.waitForExit()` in cases where we do not validate the exit code or check that no errors are displayed in the output, just assuming that the shell exited successfully, but instead intentionally always validate that these conditions are true in the cases in which we expect them to be.
nirinchev
approved these changes
Dec 12, 2024
Collaborator
nirinchev
left a comment
nirinchev
left a comment
There was a problem hiding this comment.
Nice restructuring - I like the more explicit helper names. The test failures seem legit though and we should fix them before merging.
Collaborator
Author
|
@nirinchev Yeah – #2298 and #2300 should address these. Part of the motivation for this change here is that, had we always used this "explicitly await success or failure", that issue would have been much more visible since it would have shown up as a consistent failure, not a flaky one 🙂 |
gagik
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use unqualified
shell.waitForExit()in cases where we do not validate the exit code or check that no errors are displayed in the output, just assuming that the shell exited successfully, but instead intentionally always validate that these conditions are true in the cases in which we expect them to be.